No header display when exactly at $container-width #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating Millennial, I’ve been using it for a few years now!
I noticed that when the screen width is exactly 1100px wide ($container-width), the header will not display the menu links, nor the dropdown menu.
This is due to 2 conflicting CSS media queries within _sass/_header.scss at:
Millennial/_sass/_header.scss
Line 43 in 38541ba
Millennial/_sass/_header.scss
Line 51 in 38541ba
The issue is that the logic of both queries is inclusive, so when the screen width is exactly equal to $container-width, both queries are trying to add their attributes.
The fix will make it so that when the screen width is exactly $container-width, the dropdown menu will show.