Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No header display when exactly at $container-width #81

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

kyletimmermans
Copy link

@kyletimmermans kyletimmermans commented Feb 3, 2024

Thank you for creating Millennial, I’ve been using it for a few years now!

I noticed that when the screen width is exactly 1100px wide ($container-width), the header will not display the menu links, nor the dropdown menu.

This is due to 2 conflicting CSS media queries within _sass/_header.scss at:

@media (min-width: $container-width) {

@media (max-width: $container-width) {

The issue is that the logic of both queries is inclusive, so when the screen width is exactly equal to $container-width, both queries are trying to add their attributes.

The fix will make it so that when the screen width is exactly $container-width, the dropdown menu will show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant