Fix #266: restore in TS 5.6. #270
Open
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed to compile `transform-typescript-paths` due to many TypeScript compilation errors. Therefore, don't know whether this PR is valid or not. Hope your strict your review @nonara. Instead, tested on my project manually editing the JS file in the `node_modules/typescript-transform-paths` directory.
|
Thanks for contributing @samchon, it seems the build is failing, and I'm concerned about breaking compatibility with typescript <5.6, so we probably need to add some tests to make sure older typescript versions continue working. |
|
indeed this only requires renaming a single fn name and it breaks the core release of typescript - originalSourceFile: tsInstance.getOriginalSourceFile(sourceFile),
+ originalSourceFile: tsInstance.getSourceFileOfNode(sourceFile),made my project compile -- worst case perhaps originalSourceFile: typeof tsInstance.getSourceFileOfNode === 'function' ? tsInstance.getSourceFileOfNode(sourceFile) : tsInstance.getOriginalSourceFile(sourceFile)ah it does seem entirely type based - id be surprised if it didnt require a major change due to them removing a bunch of stuff in 5.6 via knip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to compile
transform-typescript-pathsdue to many TypeScript compilation errors. Therefore, don't know whether this PR is valid or not. Hope your strict your review @nonara.Instead, tested on my project manually editing the JS file in the
node_modules/typescript-transform-pathsdirectory.