Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 simplify read examples #1035

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

🧹 simplify read examples #1035

wants to merge 20 commits into from

Conversation

St0rmBr3w
Copy link
Contributor

No description provided.

Copy link

socket-security bot commented Nov 17, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Unpopular package npm/@layerzerolabs/[email protected] ⚠︎
Unpopular package npm/@layerzerolabs/[email protected] ⚠︎

View full report↗︎

Next steps

What are unpopular packages?

This package is not very popular.

Unpopular packages may have less maintenance and contain other problems.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@janjakubnanista janjakubnanista changed the title chore: simplify read examples 🧹 simplify read examples Nov 18, 2024
Copy link
Contributor

@janjakubnanista janjakubnanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small stuff

@yargo13 yargo13 force-pushed the feat/simple-read-examples branch from 8907e13 to f3821b4 Compare November 19, 2024 17:30
Copy link

socket-security bot commented Nov 19, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@layerzerolabs/[email protected] None +1 1.4 MB layerzero-bot

View full report↗︎

@St0rmBr3w St0rmBr3w force-pushed the feat/simple-read-examples branch from 8c50dc4 to 972871a Compare November 24, 2024 05:16
@ryandgoulding
Copy link
Contributor

Fixed pnpm-lock.yaml. Running through CI pipeline.

@nazreen
Copy link
Contributor

nazreen commented Nov 28, 2024

This PR is awesome. when can we have this in main ?

uint32 _readChannel
) OAppRead(_endpoint, _delegate) Ownable(_delegate) {
READ_CHANNEL = _readChannel;
_setPeer(_readChannel, AddressCast.toBytes32(address(this)));
Copy link
Contributor

@shankars99 shankars99 Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not review but why doesnt OAppRead set self peer? in lzRead we always self peer dont we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OAppRead shouldn't override setPeer since than if you used it for just messaging you wouldn't be able to.

addressToBytes32(address(bOApp)),
0,
address(0x0),
abi.encode(a + b) // The sum of a and b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuzz here because a+b could overflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is unnecessary since this is an example contract, there will likely be edge cases that cause a + b to overflow.

@St0rmBr3w St0rmBr3w force-pushed the feat/simple-read-examples branch from 1ecfa5c to de2ed56 Compare February 21, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants