Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 http response status codes #62

Merged
merged 11 commits into from
Sep 1, 2023

Conversation

philippschwarzmueller
Copy link
Collaborator

No description provided.

@philippschwarzmueller philippschwarzmueller linked an issue Aug 31, 2023 that may be closed by this pull request
this->has_request_error_ = true;
this->request_error_ = STATUS_505;
} else if (this->getContentLength() < this->body_.size()) {
// TODO: this case leads to timeout in the servers main loop, we never get
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this lead to timeout?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be explored in #61

Copy link
Owner

@LaurinUB LaurinUB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other then the TODO LGTM

@philippschwarzmueller philippschwarzmueller merged commit 8d28ac7 into main Sep 1, 2023
1 check passed
@philippschwarzmueller philippschwarzmueller deleted the 24-http-response-status-codes branch September 1, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement HTTP response status codes
2 participants