Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linear Map View #251

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Linear Map View #251

wants to merge 1 commit into from

Conversation

isaacguerreir
Copy link
Contributor

@isaacguerreir isaacguerreir commented Dec 12, 2023 •
edited
Loading

#231

  • Ruler component created
  • Linear Map component created
  • Ticks integrated to component
  • Annotations integrated to component
  • Cut sites integrated to component

isaacguerreir
isaacguerreir commented Dec 13, 2023
View reviewed changes
src/LinearMap/Index.tsx
seqLength: number
}

export function Index(props: IndexProps) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I use functional components @jjti ou should I maintain the class components being used throughout the project?

@isaacguerreir
Copy link
Contributor Author

Linear and Linear Map have too much overlap meaningful-wise. I would like to know if we can think of another proposition. One example could be:
Linear -> SequenceDetails
LinearMap -> Linear

@jjti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@isaacguerreir