Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client into bugfix-포스트수정-오류-수정
Josh5519
reviewed
Aug 21, 2023
src/components/Editor.jsx
Outdated
Comment on lines
33
to
31
| return () => { | ||
| if (ref.current) { | ||
| ref.current.destroy(); | ||
| }); |
There was a problem hiding this comment.
useEffect 마지막에 해제 하는거 지우셨는데 없어도 되는 코드인가요?
There was a problem hiding this comment.
수정할 때 여기에서 에러가 발생했던 걸로 기억하는데, 혹시 어떤 이유였는지 설명해주실 수 있을까요?
There was a problem hiding this comment.
네 기존에는 생성되는 EditorJS 인스턴스가 메모리에 계속 남아서 있어서 destroy로 제거해줬는데
바뀐 방법에는 이미 존재하면 새로운 EditorJS 인스턴스를 생성하지 않고 기존 인스턴스를 재사용하여 destroy를 사용하지 않아도 됩니다.
Josh5519
reviewed
Aug 21, 2023
src/components/Editor.jsx
Outdated
Comment on lines
56
to
62
| let response = {}; | ||
|
|
||
| if (isModify) { | ||
| await axios.put(`/api/v1/posts/${postId}`, postData); | ||
| router.push(`/posts/${author}`); | ||
| response = await axios.put(`/api/v1/posts/${postId}`, postData); | ||
| } else { | ||
| response = await axios.post('/api/v1/posts', postData); | ||
| } |
There was a problem hiding this comment.
삼항 연산자를 쓰면 response를 const로 선언해서 사용할 수 있을 것 같습니다.
There was a problem hiding this comment.
네 의견 감사합니다.
반영하였습니다.
hamsterster
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 목적
포스트 수정 관련 포스트 생성 컴포넌트 및 이미지 저장 API 오류 수정 작업 #18
2023-08-21.8.01.40.mov
📑 작업 내용
🚧 주의 사항