#61

- #61: Add 'Show Strike Images' module setting.
Larkinabout · Jun 30, 2023 · 776bfb4 · 776bfb4
1 parent 6e19127
commit 776bfb4
Show file tree

Hide file tree

Showing 15 changed files with 67 additions and 5 deletions.
diff --git a/languages/br.json b/languages/br.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/cn.json b/languages/cn.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/de.json b/languages/de.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/en.json b/languages/en.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/es.json b/languages/es.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/fr.json b/languages/fr.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/it.json b/languages/it.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/ja.json b/languages/ja.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/ko.json b/languages/ko.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/pl.json b/languages/pl.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/languages/zh-tw.json b/languages/zh-tw.json
@@ -21,6 +21,10 @@
                     "hint": "Choose whether to color skills by their rank",
                     "name": "Color Skills by Rank"
                 },
+                "showStrikeImages": {
+                    "hint": "Choose whether to show strike images by default",
+                    "name": "Show Strike Images"
+                },
                 "showStrikeNames": {
                     "hint": "Choose whether to show strike names by default",
                     "name": "Show Strike Names"

diff --git a/module.json b/module.json
@@ -95,7 +95,7 @@
         "compatibility": [
           {
             "minimum": "4.6.4",
-            "verified": "5.0.0-beta2"
+            "verified": "5.0.2"
           }
         ]
       }

diff --git a/scripts/action-handler.js b/scripts/action-handler.js
@@ -52,6 +52,7 @@ Hooks.once('tokenActionHudCoreApiReady', async (coreModule) => {
             this.abbreviateSkills = Utils.getSetting('abbreviateSkills')
             this.calculateAttackPenalty = Utils.getSetting('calculateAttackPenalty')
             this.colorSkills = Utils.getSetting('colorSkills')
+            this.showStrikeImages = Utils.getSetting('showStrikeImages')
             this.showStrikeNames = Utils.getSetting('showStrikeNames')
             this.splitStrikes = Utils.getSetting('splitStrikes')
             this.addDamageAndCritical = Utils.getSetting('addDamageAndCritical')
@@ -1297,10 +1298,11 @@ Hooks.once('tokenActionHudCoreApiReady', async (coreModule) => {
                 }
                 const tooltip = await this.#getTooltip(tooltipData)
                 // Create group data
-                strikeGroupData = { id: strikeGroupId, name: strikeGroupName, listName: strikeGroupListName, type: 'system-derived', settings: { image, showTitle }, tooltip }
+                strikeGroupData = { id: strikeGroupId, name: strikeGroupName, listName: strikeGroupListName, type: 'system-derived', settings: { showTitle }, tooltip }
+                if (this.showStrikeImages) { strikeGroupData.settings.image = image }
 
                 // Add group to action list
-                this.addGroup(strikeGroupData, parentGroupData, true)
+                this.addGroup(strikeGroupData, parentGroupData)
 
                 if (strike.auxiliaryActions?.length) {
                     // Get actions

diff --git a/scripts/settings.js b/scripts/settings.js
@@ -33,6 +33,22 @@ export function register (updateFunc) {
         }
     })
 
+    game.settings.register(MODULE.ID, 'showStrikeImages', {
+        name: game.i18n.localize(
+            'tokenActionHud.pf2e.settings.showStrikeImages.name'
+        ),
+        hint: game.i18n.localize(
+            'tokenActionHud.pf2e.settings.showStrikeImages.hint'
+        ),
+        scope: 'client',
+        config: true,
+        type: Boolean,
+        default: true,
+        onChange: (value) => {
+            updateFunc(value)
+        }
+    })
+
     game.settings.register(MODULE.ID, 'showStrikeNames', {
         name: game.i18n.localize(
             'tokenActionHud.pf2e.settings.showStrikeNames.name'
@@ -43,7 +59,7 @@ export function register (updateFunc) {
         scope: 'client',
         config: true,
         type: Boolean,
-        default: true,
+        default: false,
         onChange: (value) => {
             updateFunc(value)
         }

diff --git a/scripts/token-action-hud-pf2e.min.js b/scripts/token-action-hud-pf2e.min.js