Bump DataTables version & fix header alignment #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxpm
commented
Nov 25, 2024
pxpm
commented
Nov 25, 2024
pxpm
force-pushed
the
next
branch
2 times, most recently
from
0cffae1 to
8ece6d2
Compare
tabacitu
changed the title
tabacitu
changed the title
|
@pxpm I can confirm this PR fixes the alignment issue (omfg finally!), and it works for most CRUDS. But I noticed it also breaks a few CRUDs in our demo - Invoices CRUD, Pets CRUD:
|
pxpm
force-pushed
the
update-datatables
branch
from
17f4a97 to
e2a69de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
We were lagging ALOT in datatables versions. Major improvements and bug fixes had been made in the meanwhile, and we were not benefiting from it. Eg: the fixed header alignment: #4853
The reason was the amount of hours I need to spend to track and fix the issues that popped up just by bumping the datatables version in the cdn url. It's done 👍
AFTER - What is happening after this PR?
We are on the bleeding egde of datatables, future upgrades will be WAY easier. It looks to me that the table performs a little better.
Is it a breaking change?
I don't think so 🤷♂️