update url column - add rel=noreferrer and fix attribute definition #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
fixes: Laravel-Backpack/community-forum#507
BEFORE - What was wrong? What was happening before this PR?
The url column could leak your admin panel url if developer didn't took care of adding the
relattribute to the column wrapper.In addition, the docs stated that you could use
'target' => '_blank'in your column definition, but that was not actually working because the column was just checking the values in the wrapper.AFTER - What is happening after this PR?
We add by default a
rel="noreferrer"to the url column type and the column now checks fortarget,elementandrelon the column definition, not only in the wrapper.Is it a breaking change?
I think it is not.
DOCS: Laravel-Backpack/docs#600