Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sidebar.blade.php #3121

Closed
wants to merge 1 commit into from
Closed

Update sidebar.blade.php #3121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/resources/views/base/inc/sidebar.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ function() { return $(this).attr('href') === full_url; }
// If not found, look for the link that starts with the url
if(!$curentPageLink.length > 0){
$curentPageLink = $navLinks.filter( function() {
if ($(this).attr('href').startsWith(full_url)) {
if ($(this).attr('href').split('?')[0] === full_url) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript's split always returns an array with at least one value, so even if there's no ? this still works as expected.

return true;
}

if (full_url.startsWith($(this).attr('href'))) {
if (full_url.split('?')[0] === $(this).attr('href')) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

return true;
}

Expand Down