feat: embed lyrics in file #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to embed lyrics directly into audio files. It includes: - Adding TagLib dependency for metadata manipulation . - Implementing `embedLyricsInFile` function in `MainViewModel` to handle embedding. - Adding a toggle in settings to enable/disable embedding. - Updating lyrics saving logic to use embedding when enabled. - Handling potential `SecurityException` during embedding on Android Q+.
Adds a button to embed lyrics in the song file. Removes the embed lyrics in file preference.
This commit includes minor code style improvements such as fixing formatting inconsistencies and optimizing imports. These changes enhance the readability and maintainability of the codebase.
|
This should be ready. Please, test it to check if everything works correctly. |
Handle embedding lyrics into non-local songs by displaying a user-friendly error message. Improve error handling for embedding lyrics and show specific error messages for different scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to embed lyrics directly into audio files. It includes:
embedLyricsInFilefunction inMainViewModelto handle embedding.SecurityExceptionduring embedding on Android Q+.