LibWeb/Streams: Store PullIntoDescriptors in an IntrusiveList #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbooth
commented
Jan 19, 2025
This was needed before PullIntoDescriptor was a cell type where the shift would destroy the underlying storage. Now that it's a GC::Cell, the Ref that we have on the stack keeps it alive, even after the shift removes it from the controller which normally visits it.
shannonbooth
force-pushed
the
intrusive-list
branch
from
7262455 to
a00223e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was needed before PullIntoDescriptor was a cell type where the
shift would destroy the underlying storage. Now that it's a GC::Cell,
the Ref that we have on the stack keeps it alive, even after the shift
removes it from the controller which normally visits it.