LibWeb: Implement dialog.requestClose() #3280
Open
+150
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test passes when running in the browser and when imported, but if I run with the test runner I get same error as CI, it seems something is flaky and can lead to two close events being fired (at least according to the test) It makes use of abort signal and I'm wondering if there's an issue with Ladybird's impl? |
lukewarlow
force-pushed
the
dialog-requestclose
branch
from
7562e5d to
d96ca7f
Compare
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
github-actions
bot
added
the
conflicts
lukewarlow
force-pushed
the
dialog-requestclose
branch
from
d96ca7f to
406c68d
Compare
github-actions
bot
removed
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://html.spec.whatwg.org/multipage/interaction.html#dom-closewatcher-requestclose
Can manually test using https://wpt.live/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose.html where it passes all tests.
If I import the test it's flaky and sometimes fails on test runner.