Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibJS: Implement Temporal.Instant and Temporal.Now #2557

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

trflynn89
Copy link
Contributor

This gives the following test262 diff over current master:

+459 ✅    -459 ❌

With the following tests fixed over our previous Temporal.Instant and Temporal.Now implementations:

test/built-ins/Temporal/Instant/compare/argument-string-multiple-calendar.js                     ❌ -> ✅
test/built-ins/Temporal/Instant/compare/argument-wrong-type.js                                   ❌ -> ✅
test/built-ins/Temporal/Instant/from/argument-string-multiple-calendar.js                        ❌ -> ✅
test/built-ins/Temporal/Instant/from/argument-wrong-type.js                                      ❌ -> ✅
test/built-ins/Temporal/Instant/from/instant-string-sub-minute-offset.js                         ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/add/argument-not-object.js                             ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/add/argument-string-negative-fractional-units.js       ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/epochMilliseconds/basic.js                             ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/equals/argument-string-multiple-calendar.js            ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/equals/argument-wrong-type.js                          ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/equals/instant-string-sub-minute-offset.js             ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/round/rounding-direction.js                            ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/since/argument-string-multiple-calendar.js             ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/since/argument-wrong-type.js                           ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/since/instant-string-sub-minute-offset.js              ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/since/order-of-operations.js                           ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/subtract/argument-not-object.js                        ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/subtract/argument-string-negative-fractional-units.js  ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-non-integer.js         ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/toString/order-of-operations.js                        ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/toString/rounding-direction.js                         ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/toString/timezone-string-datetime.js                   ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/toString/timezone-string-sub-minute-offset.js          ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/toString/timezone-wrong-type.js                        ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-missing.js                 ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/until/argument-string-multiple-calendar.js             ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/until/argument-wrong-type.js                           ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/until/instant-string-sub-minute-offset.js              ❌ -> ✅
test/built-ins/Temporal/Instant/prototype/until/order-of-operations.js                           ❌ -> ✅
test/built-ins/Temporal/Now/plainDateISO/timezone-string-datetime.js                             ❌ -> ✅
test/built-ins/Temporal/Now/plainDateISO/timezone-string-sub-minute-offset.js                    ❌ -> ✅
test/built-ins/Temporal/Now/plainDateISO/timezone-wrong-type.js                                  ❌ -> ✅
test/built-ins/Temporal/Now/plainDateTimeISO/timezone-string-datetime.js                         ❌ -> ✅
test/built-ins/Temporal/Now/plainDateTimeISO/timezone-string-sub-minute-offset.js                ❌ -> ✅
test/built-ins/Temporal/Now/plainDateTimeISO/timezone-wrong-type.js                              ❌ -> ✅
test/built-ins/Temporal/Now/plainTimeISO/timezone-string-datetime.js                             ❌ -> ✅
test/built-ins/Temporal/Now/plainTimeISO/timezone-string-sub-minute-offset.js                    ❌ -> ✅
test/built-ins/Temporal/Now/plainTimeISO/timezone-wrong-type.js                                  ❌ -> ✅
test/built-ins/Temporal/Now/timeZoneId/extensible.js                                             ❌ -> ✅
test/built-ins/Temporal/Now/timeZoneId/length.js                                                 ❌ -> ✅
test/built-ins/Temporal/Now/timeZoneId/name.js                                                   ❌ -> ✅
test/built-ins/Temporal/Now/timeZoneId/not-a-constructor.js                                      ❌ -> ✅
test/built-ins/Temporal/Now/timeZoneId/prop-desc.js                                              ❌ -> ✅
test/built-ins/Temporal/Now/timeZoneId/return-value.js                                           ❌ -> ✅

All callers currently handle this without needing any further changes.
And the simple Temporal.Instant.prototype getters, so that the
constructed Temporal.Instant may actually be validated.
@awesomekling awesomekling merged commit f2c19f9 into LadybirdBrowser:master Nov 25, 2024
6 checks passed
@trflynn89 trflynn89 deleted the temporal_instant branch November 25, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants