LibWeb: Store CSS color name in CSSRGB #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcl3
reviewed
Nov 24, 2024
milotier
force-pushed
the
wpt-style-attribute
branch
2 times, most recently
from
1280920 to
45b7fd8
Compare
When serializing an sRGB color value that originated from a named color, it should return the color name converted to ASCII lowercase. This requires storing the color name (if it has one). This change also requires explicitly removing the color names when computing style, because computed color values do not retain their name. It also requires removing a caching optimization in create_from_color(), because adding the name means that the cached value might be wrong. This fixes some WPT subtests, and also required updating some of our own tests.
milotier
force-pushed
the
wpt-style-attribute
branch
from
45b7fd8 to
70e9cc2
Compare
|
The rest of the "failing" tests were actually correct, the expected output just had to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing an sRGB color value that originated from a named color, it should simply return the color name. This requires storing the color name (if it has one).
This fixes 2 WPT subtests of https://wpt.fyi/results/domparsing/style_attribute_html.html?label=master&product=ladybird.
This is the easiest way I could find to store the original color name, though there is also the option of storing an enum.