Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup more includes #2468

Merged

Conversation

shlyakpavel
Copy link
Contributor

@shlyakpavel shlyakpavel commented Nov 20, 2024

All the changes are atomic, any commit within this PR builds separately

I don't just cleanup unused includes, but also replace some includes to the files where they are actually used.

@shlyakpavel shlyakpavel force-pushed the cleanup_libregex_includes branch from 6132996 to 3c8ff62 Compare November 20, 2024 22:54
@shlyakpavel shlyakpavel marked this pull request as draft November 20, 2024 23:02
@shlyakpavel shlyakpavel force-pushed the cleanup_libregex_includes branch 8 times, most recently from 1797317 to 2ba4a1f Compare November 21, 2024 00:20
@shlyakpavel shlyakpavel marked this pull request as ready for review November 21, 2024 02:10
This change aims to improve the speed of incremental builds.
This change aims to improve the speed of incremental builds.
This change aims to improve the speed of incremental builds.
This change aims to improve the speed of incremental builds.
This change aims to improve the speed of incremental builds.
This change aims to improve the speed of incremental builds.
This change aims to improve the speed of incremental builds.
@shlyakpavel shlyakpavel force-pushed the cleanup_libregex_includes branch from 2ba4a1f to 6eefb6a Compare November 21, 2024 10:56
@shlyakpavel
Copy link
Contributor Author

shlyakpavel commented Nov 21, 2024

Rebased on master

@kalenikaliaksandr kalenikaliaksandr merged commit 001df24 into LadybirdBrowser:master Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants