LibWeb: Add missing base class upcalls in Node::inserted() overrides

LadybirdBrowser · Jan 23, 2025 · 9e59296 · 9e59296
1 parent c4f358f
commit 9e59296
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/Libraries/LibWeb/HTML/HTMLDetailsElement.cpp b/Libraries/LibWeb/HTML/HTMLDetailsElement.cpp
@@ -45,6 +45,8 @@ void HTMLDetailsElement::initialize(JS::Realm& realm)
 // https://html.spec.whatwg.org/multipage/interactive-elements.html#the-details-element:html-element-insertion-steps
 void HTMLDetailsElement::inserted()
 {
+    Base::inserted();
+
     // 1. Ensure details exclusivity by closing the given element if needed given insertedNode.
     ensure_details_exclusivity_by_closing_the_given_element_if_needed();
 

diff --git a/Libraries/LibWeb/HTML/HTMLMeterElement.cpp b/Libraries/LibWeb/HTML/HTMLMeterElement.cpp
@@ -170,6 +170,7 @@ WebIDL::ExceptionOr<void> HTMLMeterElement::set_optimum(double value)
 
 void HTMLMeterElement::inserted()
 {
+    Base::inserted();
     create_shadow_tree_if_needed();
 }
 

diff --git a/Libraries/LibWeb/HTML/HTMLProgressElement.cpp b/Libraries/LibWeb/HTML/HTMLProgressElement.cpp
@@ -92,6 +92,7 @@ double HTMLProgressElement::position() const
 
 void HTMLProgressElement::inserted()
 {
+    Base::inserted();
     create_shadow_tree_if_needed();
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     void HTMLMeterElement::inserted()
     {
+        Base::inserted();
         create_shadow_tree_if_needed();
     }
@@ Expand Down @@