LibWeb: Make SVGSVGElement.getElementById() return Element? (nullable)

This is wrong in the spec, and there's already a bug open.
LadybirdBrowser · Jan 21, 2025 · 96e074b · 96e074b
1 parent 8b097b3
commit 96e074b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/Libraries/LibWeb/SVG/SVGSVGElement.idl b/Libraries/LibWeb/SVG/SVGSVGElement.idl
@@ -29,7 +29,8 @@ interface SVGSVGElement : SVGGraphicsElement {
     SVGTransform createSVGTransform();
     [FIXME] SVGTransform createSVGTransformFromMatrix(optional DOMMatrix2DInit matrix = {});
 
-    Element getElementById(DOMString elementId);
+    // NOTE: The spec says this returns `Element` but that's a bug: https://github.com/w3c/svgwg/issues/923
+    Element? getElementById(DOMString elementId);
 
     // Deprecated methods that have no effect when called,
     // but which are kept for compatibility reasons.

diff --git a/Tests/LibWeb/Text/expected/SVG/svg-svg-getElementById.txt b/Tests/LibWeb/Text/expected/SVG/svg-svg-getElementById.txt
@@ -0,0 +1 @@
+PASS: true
diff --git a/Tests/LibWeb/Text/input/SVG/svg-svg-getElementById.html b/Tests/LibWeb/Text/input/SVG/svg-svg-getElementById.html
@@ -0,0 +1,8 @@
+<script src="../include.js"></script>
+<svg id="svgRoot"></svg>
+<script>
+    test(() => {
+        const x = svgRoot.getElementById("x");
+        println(`PASS: ${x === null}`);
+    });
+</script>