Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nice-City.de #722

Closed
wants to merge 40 commits into from
Closed

Add Nice-City.de #722

wants to merge 40 commits into from

Conversation

NiceRecord
Copy link
Contributor

@NiceRecord NiceRecord commented Oct 1, 2023 •
edited
Loading

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

github-actions[bot]
github-actions bot requested changes Oct 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/nice-city/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Oct 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/EnderMine/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

DoJapHD
DoJapHD requested changes Oct 31, 2023
View reviewed changes
minecraft_servers/EnderMine/manifest.json Outdated Show resolved Hide resolved
minecraft_servers/EnderMine/manifest.json Outdated Show resolved Hide resolved
minecraft_servers/EnderMine/[email protected] Outdated Show resolved Hide resolved
minecraft_servers/EnderMine/background.png Outdated Show resolved Hide resolved
minecraft_servers/nice-city/manifest.json Show resolved Hide resolved
minecraft_servers/nice-city/[email protected] Outdated Show resolved Hide resolved
minecraft_servers/nice-city/background.png Outdated Show resolved Hide resolved
@DoJapHD
Copy link
Collaborator

DoJapHD commented Nov 1, 2023

Some change requests still open

@DoJapHD
Copy link
Collaborator

DoJapHD commented Nov 2, 2023

One requested change is still open

@NiceRecord NiceRecord closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD requested changes

@github-actions github-actions[bot] github-actions[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiceRecord @DoJapHD