Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Salesforce project.yml and objectives #1862

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Conversation

unjust
Copy link
Contributor

@unjust unjust commented Aug 16, 2024

Closes #1861

@unjust unjust self-assigned this Aug 16, 2024
@unjust unjust requested a review from marianaLz August 16, 2024 20:09
- name: salesforce-js
learningObjectives:
- salesforce/points-50000
- salesforce/badges-100
Copy link
Contributor Author

@unjust unjust Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marianaLz @merunga No se como se parece cuando tenemos los mismos OAs en el base de proyecto y los variantes. El parser necesita que un proyecto tiene OAs en el base para tener variantes, y los variantes tmb necesitan OAs (sino, tira un error).

Creo variantes eran diseñado para agregar mas OAs a los OAs de base. Si podemos pensar en un OA base que es distinta, vale. Si no, creo los variantes va apaerecer igual, pero no se si los OAs van a duplicar (base + variante)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quiza todo bien porque asi es como parece el json, con variantes pero sin OAs duplicados

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece bien dejarlo así, la otra opció sería que el OA base son 100 badges y las internas son: 51,600 puntos para platform y 57,400 puntos para JS, cómo lo es @merunga ??

@unjust unjust changed the base branch from main to next August 16, 2024 20:37
@unjust unjust added this to the v9.4.0 DevOps Projects milestone Aug 16, 2024
@unjust unjust merged commit 8a422d0 into next Aug 16, 2024
4 checks passed
@unjust unjust deleted the salesforce-objectives branch August 16, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agregar OAs para los variantes de Salesforce
2 participants