Fix remove extra docs in Dataverse and edit title #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
unjust
commented
Sep 21, 2023
unjust
commented
- Borrar viejo README pt de datalovers
- Titulo "Dataverse"
- Borrar EXTRA y FAQ
- Mover algunos links de FAQ a Pistas, tips, lecturas complementarias
Davichobits
reviewed
Sep 21, 2023
Co-authored-by: David Ruiz <[email protected]>
merunga
added a commit
to merunga/curriculum
that referenced
this pull request
Sep 22, 2023
* feat(deps): Added Vite * config: removes duplicate key and adds (for now empty but mut be changed) process.env def * chore(deps): Updates @laboratoria/react/dist imports to @laboratoria/react/src as per last release * feat(workflow): Updates env variable examples and updates github ci/cd workflows with new variables - deprecates REACT_APP_ variables and the set-output task * chore(config): Updates vite config file and @laboratoria/react dependency * fix(lib): Undo changes to lib/data.js process.env * chore(deps): Removes react-scripts and webpack config file * fix(package.json): removes type module * fix(vite cofig): Adds dotenv() to vite.config file * chore(deps): Update dependencies and adds dotenv dep * fix(env/workers): Updates env variables and fixes workers/ symlink * fix(gh actions): Fixes Laboratoria api urls * fix(config): Fixes env variable name in Vite config file * chore(deps): Updates @laboratoria/react dependency with ace editor fixes * feat(vitest): Adds Vitest, jsdom, test setup in vite.config.js, moves __mocks__ to root dir and fixes components tests * chore(deps): Removes unused Jest config * fix(test): Fixes Topic test in node 20 * chore(docs): Actualiza todas las referencias antiguas del repo Laboratoria/bootcamp a Laboratoria/curriculum * chore(release): Bumps version to v7.0.0 and updates dist files * fix(project docs): Adds thumbnails to UX projects READMEs * fix(assets): Fixes outdated 01-design-and-usability thumbnail * feat(sentry): Adds Sentry config function from @laboratoria/react in src/index.jsx and adds the corresponding variable to github actions (Laboratoria#1554) * fix(yml): add titles and links for some oas typescript (Laboratoria#1556) * fix: add titles and links for some oas typescript * fix: oas typescript portuguese * space * Update learning-objectives/intl/es.yml * Convert Fleet Management Service Project from fullstack to backend (Laboratoria#1542) * Convert project from fullstack to backend * CLI specifications, poor performance by default, pagination * feat: Adds prompting learning objectives addresses Laboratoria#1510 (Laboratoria#1567) * adds prompting OAs and translation en es * portugues, corrections * Apply suggestions from code review Co-authored-by: Alfredo González <[email protected]> * simplify oas * few shot prompting * cambia titulos de recursos * quitar prompting oa de data lovers * Update learning-objectives/intl/es.yml Co-authored-by: David Ruiz <[email protected]> --------- Co-authored-by: Alfredo González <[email protected]> Co-authored-by: David Ruiz <[email protected]> * chore(release): Bumps version to v7.1.0 and updates dist files * fix: Reemplazar create react app, fixes Laboratoria#1453 (Laboratoria#1555) * falta imagen para reemplazar * imagen react * sin create-react-app, con imagen * con creacion de carpeta * mdlint * mdlint espacios en heading * sin coma * eliminar procedimiento * eliminar imagen * espacio debajo de los titulos * Update projects/04-notes/README.md Co-authored-by: Ivy Feraco <[email protected]> * descripción de linkk --------- Co-authored-by: Ivy Feraco <[email protected]> * fix: cambios con feedback DEV011 - resaltar root, modificar instrucciones Addresses Laboratoria#1577 (Laboratoria#1587) * resaltar root, modificar instruccion de view * cambio de instrucciones en dataFunctions, cambiar el console.log para ejecutar las funciones, añadir parametro en view.js * mejorar instrucciones en dataFunctions * espacios despues comments * Quita prototipo de baja, reordenar indice --------- Co-authored-by: Ivy Feraco <[email protected]> Co-authored-by: Ivy Feraco <[email protected]> * fix: remove extra docs in Dataverse and edit title (Laboratoria#1586) * remove EXTRA and old data lovers README in pt * move some resources to main README, delete FAQ * Apply suggestions from code review, acentos etc. Co-authored-by: David Ruiz <[email protected]> * Update README.md quita card class --------- Co-authored-by: David Ruiz <[email protected]> * fix: adds prompting objectives to project.yml (Laboratoria#1585) --------- Co-authored-by: Alfredo González <[email protected]> Co-authored-by: Alfredo González <[email protected]> Co-authored-by: Ivy Feraco <[email protected]> Co-authored-by: Sergio Sinuco <[email protected]> Co-authored-by: David Ruiz <[email protected]> Co-authored-by: ivy <[email protected]> Co-authored-by: DeysiVergara <[email protected]>
unjust
pushed a commit
that referenced
this pull request
Sep 28, 2023
…rt-1 (#1604) * boilerplate for data lovers makeover * rename and reorder contents, add section objetivos aprendizaje al readme * renderitems * cambios del feedback en tests e2e, oas, boilerplate, y readme * mata errores mdlint * Ultimos cambios feedback 1 (#1541) * quita package.lock * viewFunctions -> view * move file * Aplicamos cambios de prompting al readme * Borrado de data de ejemplo y agregado de data generada por AI y test * Dentro del resumen del proyecto: 'Construirás una página web' primero * Cambio de 'cálculo agregado' por 'estadística' * Cambio de orden entre Consideraciones Generales y Funcionalidades * Cambio en el diagrama de boilerplate, dejo carpeta tests-read-only vacía * sección Prompt Utilizado agregada * Acento en propósito * Agregado de wireframes mobile de ejemplo * Referencia al screenshot del prompt utilizado dentro de Consideraciones Generales * Cambio en tiempo máximo de tiempo para generar los datos * Cambio de usuarios por usuarias * Cambio de extensión archivos de datos data.json a .js * Cambio de texto haciendo referencia al archivo javascript en vez de .json * usuario -> usuaria en todo el readme * Cambio en texto dentro de parentesis en Historias de Usuaria * Varios cambios en redacción sugeridos por Sergio * Requisito de mínimo 100 palabras agregado a descripcion * agregado de descripcion larga a los datos de ejemplo * agregado de -que vas a generar con prompting- en Resumen del proyecto * acento agregado en la palabra técnicas * Agregado de petición de captura de prompt en Consideraciones para pedir PF * Revisión general de todo el readme * Cambios pequeños - revisión Sergio * cambios en archivo oas-js-datatypes.js * Redacción recomendando páginas sobre generación de imágenes con IA * corrección en número de assertions * historias de usuaria -> usuario * explicación de chat con data en -Generar los datos- * Cambio img -> imgSrc * Corrección: data ahora tiene descripciones con más de 100 palabras * Agregado: tests para verificar que la longitud de la descipción sea mas de 100 palabras y verificacion de URL * Agregado: expect.assertions en los tests de las propiedades -value- y -label- * agregado de assertions en todos los tests * Apply suggestions from code review * Cambiando sugerencia de generador de imagenes a Bing * Pull con cambio pequeño de de Ivy * moving files into 02-dataverse-explorers, checkout 02-data-lovers from main (#3) * Update README.md for mdlint errors * fix: cambios con feedback DEV011 - resaltar root, modificar instrucciones Addresses #1577 (#1587) * resaltar root, modificar instruccion de view * cambio de instrucciones en dataFunctions, cambiar el console.log para ejecutar las funciones, añadir parametro en view.js * mejorar instrucciones en dataFunctions * espacios despues comments * Quita prototipo de baja, reordenar indice --------- Co-authored-by: Ivy Feraco <[email protected]> Co-authored-by: Ivy Feraco <[email protected]> * fix: remove extra docs in Dataverse and edit title (#1586) * remove EXTRA and old data lovers README in pt * move some resources to main README, delete FAQ * Apply suggestions from code review, acentos etc. Co-authored-by: David Ruiz <[email protected]> * Update README.md quita card class --------- Co-authored-by: David Ruiz <[email protected]> * fix: adds prompting objectives to project.yml (#1585) * fix: dataset changes, diversificacion y tests addresses #1576 (#1589) * Dataverse: Data spec * Dataverse: Nueva data * Dataverse: Data test * dataverse: apply comments * dataverse: fix asasertions call. remove old tests. reference new test in README * fix: renaming dataverse project (no explorers) * fix: script test in package.json fail in windows (#1592) * fix: dataverse images y tests de facts #1580 (#1599) * Dataverse: Data spec * Dataverse: Nueva data * Dataverse: Data test * dataverse: apply comments * dataverse: fix asasertions call. remove old tests. reference new test in README * dataverse: test para 3 propiedades compartidas en facts * dataverse: dataset images --------- Co-authored-by: merunga <[email protected]> --------- Co-authored-by: Davichobits <[email protected]> Co-authored-by: DeysiVergara <[email protected]> Co-authored-by: David Ruiz <[email protected]> Co-authored-by: Mariano Crowe <[email protected]> Co-authored-by: AlexisJoselyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.