Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reemplazar create react app #1555

Merged
merged 15 commits into from
Sep 19, 2023

Conversation

DeysiVergara
Copy link
Contributor

@DeysiVergara DeysiVergara commented Sep 5, 2023

addresses #1453

@ssinuco
Copy link
Collaborator

ssinuco commented Sep 6, 2023

El unico comentario seria no agregar el procedimiento para crear las apps porque eso puede cambiar con nuevos releases de vite.

@unjust unjust linked an issue Sep 12, 2023 that may be closed by this pull request
Copy link
Contributor

@unjust unjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si no estamos mencionando nada de Vite anteriormente, agregaria una descripcion despues del link de Vite deciendo que es la herramienta que recomendamos para bootstrap/crear su applicacion.

projects/04-notes/README.md Outdated Show resolved Hide resolved
ssinuco
ssinuco previously approved these changes Sep 18, 2023
Copy link
Collaborator

@ssinuco ssinuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De acuerdo con los cambios.

projects/04-notes/README.md Outdated Show resolved Hide resolved
@DeysiVergara DeysiVergara requested a review from unjust September 19, 2023 18:51
@unjust unjust merged commit a9b6ce7 into Laboratoria:next Sep 19, 2023
4 checks passed
merunga added a commit to merunga/curriculum that referenced this pull request Sep 22, 2023
* feat(deps): Added Vite

* config: removes duplicate key and adds (for now empty but mut be changed) process.env def

* chore(deps): Updates @laboratoria/react/dist imports to @laboratoria/react/src as per last release

* feat(workflow): Updates env variable examples and updates github ci/cd workflows with new variables - deprecates REACT_APP_ variables and the set-output task

* chore(config): Updates vite config file and @laboratoria/react dependency

* fix(lib): Undo changes to lib/data.js process.env

* chore(deps): Removes react-scripts and webpack config file

* fix(package.json): removes type module

* fix(vite cofig): Adds dotenv() to vite.config file

* chore(deps): Update dependencies and adds dotenv dep

* fix(env/workers): Updates env variables and fixes workers/ symlink

* fix(gh actions): Fixes Laboratoria api urls

* fix(config): Fixes env variable name in Vite config file

* chore(deps): Updates @laboratoria/react dependency with ace editor fixes

* feat(vitest): Adds Vitest, jsdom, test setup in vite.config.js, moves __mocks__ to root dir and fixes components tests

* chore(deps): Removes unused Jest config

* fix(test): Fixes Topic test in node 20

* chore(docs): Actualiza todas las referencias antiguas del repo Laboratoria/bootcamp a Laboratoria/curriculum

* chore(release): Bumps version to v7.0.0 and updates dist files

* fix(project docs): Adds thumbnails to UX projects READMEs

* fix(assets): Fixes outdated 01-design-and-usability thumbnail

* feat(sentry): Adds Sentry config function from @laboratoria/react in src/index.jsx and adds the corresponding variable to github actions (Laboratoria#1554)

* fix(yml): add titles and links for some oas typescript (Laboratoria#1556)

* fix: add titles and links for some oas typescript

* fix: oas typescript portuguese

* space

* Update learning-objectives/intl/es.yml

* Convert Fleet Management Service Project from fullstack to backend (Laboratoria#1542)

* Convert project from fullstack to backend

* CLI specifications, poor performance by default, pagination

* feat: Adds prompting learning objectives addresses Laboratoria#1510 (Laboratoria#1567)

* adds  prompting OAs and translation en es

* portugues, corrections

* Apply suggestions from code review

Co-authored-by: Alfredo González <[email protected]>

* simplify oas

* few shot prompting

* cambia titulos de recursos

* quitar prompting oa de data lovers

* Update learning-objectives/intl/es.yml

Co-authored-by: David Ruiz <[email protected]>

---------

Co-authored-by: Alfredo González <[email protected]>
Co-authored-by: David Ruiz <[email protected]>

* chore(release): Bumps version to v7.1.0 and updates dist files

* fix: Reemplazar create react app, fixes Laboratoria#1453 (Laboratoria#1555)

* falta imagen para reemplazar

* imagen react

* sin create-react-app, con imagen

* con creacion de carpeta

* mdlint

* mdlint espacios en heading

* sin coma

* eliminar procedimiento

* eliminar imagen

* espacio debajo de los titulos

* Update projects/04-notes/README.md

Co-authored-by: Ivy Feraco <[email protected]>

* descripción de linkk

---------

Co-authored-by: Ivy Feraco <[email protected]>

* fix: cambios con feedback DEV011 - resaltar root, modificar instrucciones Addresses Laboratoria#1577 (Laboratoria#1587)

* resaltar root, modificar instruccion de view

* cambio de instrucciones en dataFunctions, cambiar el console.log para ejecutar las funciones, añadir parametro en view.js

* mejorar instrucciones en dataFunctions

* espacios despues comments

* Quita prototipo de baja, reordenar indice

---------

Co-authored-by: Ivy Feraco <[email protected]>
Co-authored-by: Ivy Feraco <[email protected]>

* fix: remove extra docs in Dataverse and edit title (Laboratoria#1586)

* remove EXTRA and old data lovers README in pt

* move some resources to main README, delete FAQ

* Apply suggestions from code review, acentos etc.

Co-authored-by: David Ruiz <[email protected]>

* Update README.md quita card class

---------

Co-authored-by: David Ruiz <[email protected]>

* fix: adds prompting objectives to project.yml (Laboratoria#1585)

---------

Co-authored-by: Alfredo González <[email protected]>
Co-authored-by: Alfredo González <[email protected]>
Co-authored-by: Ivy Feraco <[email protected]>
Co-authored-by: Sergio Sinuco <[email protected]>
Co-authored-by: David Ruiz <[email protected]>
Co-authored-by: ivy <[email protected]>
Co-authored-by: DeysiVergara <[email protected]>
@unjust unjust added this to the 7.2 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reemplazamos las referencias a create-react-app
3 participants