-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22.11 fb bilinear regression fit #637
Conversation
Add expected regression fit to parameters of AbstractQuantificationTest.runScenario
ERROR: A pull request from WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
@nickshulman let me know if you want help on updating the plots |
… generated by test in Skyline project.
@nickshulman what are the next steps on this PR. Do you want us to handle anything on the LabKey side? |
I think we should wait a month before committing this fix. |
Sounds good. Thanks for the update. |
@nickshulman Any updates on your schedule here? Have you had a chance to make the Skyline updates yet? |
@nickshulman any updates on the timing for this? @brendanx67 |
Probably beginning of May. |
@nickshulman any updates on this? Brendan mentioned this may be at risk for 23.1. |
@nickshulman is this the PR on the Skyline side that we can follow the progress and not need to nag you periodically? |
Yes, that's the PR on the Skyline side. |
…ilinear_regression_fit
Need to re-create this pull request with a different branch name targeting develop. |
@nickshulman we already branched for 23.7, so you may want to use |
Need to be fixed before merging: the calibration curve graph always draws as a straight line, even though the line for "Bilinear" is supposed to be two straight lines with a turn in it, and "Linear in log space" produces a line which is curved when plotted on a linear graph.
Rationale
Issue 43922: Add support for "Linear in Log Space" and "Bilinear" regression fit options
Related Pull Requests
Changes
Add support for "Bilinear" and "Linear in Log Space" regression fit values.