Skip to content

Improve display element builders #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Improve display element builders #1059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/org/labkey/targetedms/TargetedMSController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
import org.labkey.api.targetedms.TargetedMSUrls;
import org.labkey.api.targetedms.model.QCMetricConfiguration;
import org.labkey.api.targetedms.model.SampleFileInfo;
import org.labkey.api.util.Button;
import org.labkey.api.util.ButtonBuilder;
import org.labkey.api.util.ConfigurationException;
import org.labkey.api.util.ContainerContext;
import org.labkey.api.util.DOM;
Expand All @@ -149,7 +149,7 @@
import org.labkey.api.util.HelpTopic;
import org.labkey.api.util.HtmlString;
import org.labkey.api.util.JsonUtil;
import org.labkey.api.util.Link;
import org.labkey.api.util.LinkBuilder;
import org.labkey.api.util.PageFlowUtil;
import org.labkey.api.util.Pair;
import org.labkey.api.util.StringUtilsLabKey;
Expand Down Expand Up @@ -545,7 +545,7 @@ public ModelAndView getView(ChromatogramCrawlerForm form, boolean reshow, BindEx
{
return new HtmlView("Chromatogram Crawler", DIV("Crawl all containers under the parent " + getContainer().getPath(),
DOM.LK.FORM(at(method, "POST"),
new Button.ButtonBuilder("Start Crawl").submit(true).build())));
new ButtonBuilder("Start Crawl").submit(true).build())));
}

@Override
Expand Down Expand Up @@ -5346,7 +5346,7 @@ public static Integer addProteinSummaryViews(VBox box, PeptideGroup group, Targe

for (IKeyword keyword : keywords)
{
HtmlString link = new Link.LinkBuilder(keyword.label).href("https://www.uniprot.org/keywords/" + keyword.id).target("_blank").clearClasses().getHtmlString();
HtmlString link = new LinkBuilder(keyword.label).href("https://www.uniprot.org/keywords/" + keyword.id).target("_blank").clearClasses().getHtmlString();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HtmlString link = new LinkBuilder(keyword.label).href("https://www.uniprot.org/keywords/" + keyword.id).target("_blank").clearClasses().getHtmlString();
HtmlString link = LinkBuilder.simpleLink(keyword.label, "https://www.uniprot.org/keywords/" + keyword.id).target("_blank").getHtmlString();

if (IKeyword.BIOLOGICAL_PROCESS_CATEGORY.equals(keyword.categoryId))
extraAnnotations.computeIfAbsent("Biological Processes", k -> new ArrayList<>()).add(link);
if (IKeyword.MOLECULAR_FUNCTION_CATEGORY.equals(keyword.categoryId))
Expand Down