Skip to content

Always set Results #6741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Conversation

labkey-matthewb
Copy link
Contributor

Rationale

MissingValueDisplayColumn requires FieldKey lookup to work so we have to set Results. Internally it is hanging on to a ColumnInfo with the right FieldKey, but wrong Alias.

Related Pull Requests

Changes

…(MissingValueDisplayColumn)

Also, just removed using viewForm.getOldValues() which only contains PKs now anyway.
@labkey-jeckels
Copy link
Contributor

Is there a repro for this? I assume certain column names?

@labkey-matthewb
Copy link
Contributor Author

Is there a repro for this? I assume certain column names?

Actually, no. BiologicsDataClassTest.testAliasMultiValueDisplayColumn

The bug is simply render and update form with a DataClass/Alias field. This is due to a slight inconsistency in the implementation of MultiValuedDisplayColumn. However, there are very few places that these show up in a form.

@labkey-jeckels
Copy link
Contributor

I can see that this fixes the test, and I now understand the difference. However, in testing this, I noticed that the Organism select list at the bottom of the update doesn't repopulate correctly. It's because it's comparing a String vs an Integer here:

protected boolean isSelectInputSelected(String entryName, Object value, String valueStr)

I'm guessing it's been broken since Kevin added this code and the comment about stringifying back in 2013. Do we care about that today?

Copy link
Contributor

@labkey-klum labkey-klum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted earlier, reshow on MVFK display columns does not work, and probably never worked. The data region and table view form have different column infos because the display column toggles the bound column between the alias field key and the lookup field key.

@labkey-matthewb labkey-matthewb merged commit 5ee311c into release25.6-SNAPSHOT Jun 10, 2025
11 checks passed
@labkey-matthewb labkey-matthewb deleted the 25.6_fb_the_sequel branch June 10, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants