Issue 52684: Update Log4j plugin registration #6708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| List<String> args = new ArrayList<>(); | ||
| args.add(System.getProperty("java.home") + "/bin/java" + (SystemUtils.IS_OS_WINDOWS ? ".exe" : "")); | ||
| File labkeyBootstrap = new File(new File(new File(System.getProperty("catalina.home")), "lib"), "labkeyBootstrap.jar"); | ||
| File servletApi = null; | ||
| File labkeyBootstrap = new File(new File(System.getProperty("catalina.home")), "labkeyBootstrap.jar"); |
There was a problem hiding this comment.
I'm confused by this change. Seems like labkeyBootstrap.jar is still in a lib directory, or am I looking in the wrong place?
There was a problem hiding this comment.
Here's the layout on my dev machine. The code isn't deleting any previously extracted files. Is it an older copy, maybe?
labkey-susanh
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Log4J deprecated the approach we were using for plugin registration and started complaining about conflicting buffering configuration. Since we need to refactor how Log4J gets onto the class path, we can use this as an opportunity to share more extraction code with our tests.
Related Pull Requests
Changes
EmbeddedExtractorcode through reflection