-
Notifications
You must be signed in to change notification settings - Fork 7
Issue 53027: Cannot insert a row into a sample type if Allowed File Extensions set, no file is provided #6677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…xtensions are set and no file is provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but should we consider a site validator or similar that checks existing attachments for undesired extensions?
I added a new metric, Note that I had to remove the assert that was checking for allowed extensions when writing files to the server. Otherwise things like folder exports quickly failed unless you added all of the various extensions they'd produce. |
Rationale
We are being too picky about file uploads.
Related Pull Requests
Changes