Skip to content

Conditionalize option 'Fail import for undefined visits' during folder import #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

labkey-bpatel
Copy link
Contributor

@labkey-bpatel labkey-bpatel commented Apr 25, 2025

Rationale

The 'Fail import for undefined visits' option is displayed by default on the folder import page in Folder Management, regardless of whether the import is for a Study or a non-Study folder. It's a no-op for non-Study, however, annoying to see. This change was introduced as part of the 'Deprecate advanced import options' - see Related PR.

Related Pull Requests

Changes

  • Conditionalize option 'Fail import for undefined visits' -- logic to display or not to display this option is the same as in startPipelineImport.jsp (~line 100).

@labkey-bpatel labkey-bpatel requested review from labkey-adam and a team April 25, 2025 16:30
Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@labkey-bpatel I'd like to discuss before reviewing and your merging this PR. Since any folder archive could create a study in a currently non-study folder (and also define visits), it's not clear to me the conditions under which we would suppress this checkbox. I'm also not clear the intent reading the code. Maybe best to chat about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants