-
Notifications
You must be signed in to change notification settings - Fork 7
Improve display element builders #6558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bbimber see |
Thank you! I think I had my fill of link refactoring for the time being, but am very glad to see it added. I'll also try to break my habit of over-using PageFlowUtil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we'll need a simpleLink(String, String)
for some of my suggestions in other PRs. Probably worth it to get rid of more clearClasses()
<%@ page extends="org.labkey.api.jsp.JspTest.DRT" %> | ||
|
||
<%! | ||
@Test | ||
public void test1() | ||
{ | ||
assertTrue(1==1); | ||
ModuleLoader.getInstance().getModules().stream() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended for this PR? System.out.println()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, unintentional. That snuck out of my "ignore" change list. Reverted.
Rationale
Making our builders a bit easier to use:
org.labkey.api.util
)LinkBuilder
static factory methodssimpleLink()
andlabkeyLink()
for convenienceInputBuilder
static factory methodscheckbox()
,file()
,hidden()
,radio()
, andtext()
for convenienceJspBase.simpleLink()