Use LABKEY.Utils.helpPopup() to eliminate inline event handlers #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vagisha would be great if you could do a quick test of this page to make sure help popups still work and I didn't break anything else. I don't have a good way to test this page in context. |
labkey-matthewb
approved these changes
Mar 30, 2024
I tested this in on my dev machine. The popups still work. Thanks! |
|
👍 Thanks, @vagisha ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Old
helpPopup()helpers could generate HTML with inline events. New JavaScript helper does not.Related Pull Requests