Features/ban unban #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add databases and docker CD
Kan-A-Pesh
added
the
pending-review
Kan-A-Pesh
requested changes
Feb 27, 2024
backend/controllers/Account.ts
Outdated
| const { email } = req.body; | ||
|
|
||
| const isDevinciEmail = (email: string): boolean => { | ||
| const expression: RegExp = /^[a-zA-Z0-9._-]+@edu\.devinci.fr$/; |
There was a problem hiding this comment.
Il manque un \ sur le point
// Regex actuel
const expression: RegExp = /^[a-zA-Z0-9._-]+@edu\.devinci.fr$/;
// Regex juste
const expression: RegExp = /^[a-zA-Z0-9._-]+@edu\.devinci\.fr$/;
backend/controllers/Account.ts
Outdated
| @@ -22,6 +35,44 @@ class AccountController { | |||
| * * Send a success message | |||
| * * Send an error message if the email is invalid | |||
| */ | |||
| const { email } = req.body; | |||
|
|
|||
| const isDevinciEmail = (email: string): boolean => { | |||
There was a problem hiding this comment.
pas besoin de faire une fonction si elle n'est utilisé qu'une fois
backend/controllers/Account.ts
Outdated
| return expression.test(email); | ||
| }; | ||
|
|
||
| if (isDevinciEmail(email) == true) { |
There was a problem hiding this comment.
pas besoin de sur-vérifié la boolean if (isDevinciEmail(email)) { suffit
backend/controllers/Account.ts
Outdated
| const link: string = `url/login?token=${token}`; | ||
|
|
||
| const transporter = nodemailer.createTransport({ | ||
| host: "your_host", |
There was a problem hiding this comment.
plus judicieux de mettre une variable d'environnement (exemple. process.env.MAIL_HOST) ce qui simplifie aussi le test du code en local
backend/controllers/Account.ts
Outdated
| port: 587, | ||
| secure: true, | ||
| auth: { | ||
| user: "your_email_address", |
backend/controllers/Account.ts
Outdated
| secure: true, | ||
| auth: { | ||
| user: "your_email_address", | ||
| pass: "your_email_password", |
backend/controllers/Account.ts
Outdated
| }); | ||
|
|
||
| const message = { | ||
| from: "your_email", |
Kan-A-Pesh
added
wrong-branch
in-correction
and removed
pending-review
Kan-A-Pesh
approved these changes
Feb 29, 2024
Kan-A-Pesh
added
pending-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.