Feature/enable tp on dc non vip

[OttoRocket-LVP]

Thank you for making a contribution to Las Venturas Playground!

Please take a moment to fill in the questions in this template, to make it easier for our developers
to understand what you're doing.

What is being changed?

Disabling TP and maptp if needed. Allow non regulars to disable TP

Why is this being changed?

_We sometimes give players maptp for freeroam purpose, disable it upon reconnect to avoid abuse.
Teleportation enabling/disabling is VIP only. Thus should be enabled if player is not VIP upon connecting.

Our non regulars are new players. They sometimes have experienced shooters teleport to them, this is not fair thus allow them to disable the teleport._

How are you making the change?

[x] I have a working check-out of Las Venturas Playground.
[ ] I have included tests for any changed JavaScript code.
[ ] I have tested this change myself on my local server.

[RussellLVP]

Those conditions are getting way too complicated, we should avoid having more than 2 comparisons in a conditional, let alone five.

I think I agree with what you're doing, I'd just like to think about it a little bit more. What happens when someone has 49 hours of in-game time, toggles their setting, then, in the same session an hour later, wants to change it again? They'll be told No, right? How do we explain that?

[OttoRocket-LVP]

Yes, if they have it disabled they can not enable it anymore after playing 50 hours.
However:

• How often will the scenario happen where they will be wanting to enable it?
• They get a message saying it's a VIP command available for noobs when they use it. They also get a big message saying they're now a regular.
• We can tell them to reconnect so it resets to the default non-vip but regular value. (Enabled TP)

[RussellLVP]

Okay. I'm not convinced, but I guess I don't have to be.

[OttoRocket-LVP]

I'll poke some opinions around and see what others think :-)

[Specifer]

Just my opinion here nothing to mean any decision. I like what holsje did here, so I would like this to be implemented in the upcoming version since this can always be improved by further suggestions and discussions later. We mainly lose players because of this so this could sightly improve register rate and @OttoRocket-LVP , could you be able to add a message to that player when he gets tp'ed by anyone that he/she who is registered can turn to off/on, just for information sake?

[Specifer]

Alongside this, Does anyone think we need to add some perks to vip since a perk of theirs is available to newbies?