Feature/change the structure of the set get property to fit the variable data issue4 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-structure-of-the-set-get-property-to-fit-the-variable-data-issue4
lego8421
reviewed
Nov 10, 2022
modi/util/message_util.py
Outdated
| [values[1], 0x00, values[2], 0x00]) | ||
| return tuple(data) | ||
| return tuple(bytearray(struct.pack("f", values))) | ||
| elif data_type.find('s') != -1: |
There was a problem hiding this comment.
elif data_type in ['s8', 's16', 's32']
쓰는 타입만 걸러지게 변경
lego8421
deleted the
feature/Change-the-structure-of-the-set-get-property-to-fit-the-variable-data-issue4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.