Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/44/code cleanup #45

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Issue/44/code cleanup #45

merged 7 commits into from
Dec 2, 2024

Conversation

eacharles
Copy link
Collaborator

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (a981fca) to head (873dbf9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   97.30%   97.31%           
=======================================
  Files           9        9           
  Lines         446      447    +1     
=======================================
+ Hits          434      435    +1     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ztq1996 ztq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, that was a lot of type hintings!

@eacharles eacharles merged commit c5cbc90 into main Dec 2, 2024
5 checks passed
@eacharles eacharles deleted the issue/44/code_cleanup branch December 2, 2024 21:13
@eacharles eacharles restored the issue/44/code_cleanup branch December 2, 2024 21:13
@eacharles eacharles deleted the issue/44/code_cleanup branch December 4, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants