Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/9/survey non uniformity #25

Merged
merged 12 commits into from
Dec 18, 2023
Merged

Conversation

hangqianjun
Copy link
Contributor

Problem & Solution Description (including issue #)

Corresponds to issue #9
A rail pipline that creates data, assign observing conditions based on survey condition maps, and estimate redshifts, and assign tomographic bins.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7448207) 96.00% compared to head (359d5f1) 96.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files           2        2           
  Lines          75       75           
=======================================
  Hits           72       72           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hangqianjun hangqianjun marked this pull request as ready for review November 23, 2023 23:36
@eacharles eacharles self-requested a review November 27, 2023 17:42
Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to commit a version of the notebook that is reset, but otherwise this looks very nice. Thank you.

@hangqianjun hangqianjun merged commit 1bf79ff into main Dec 18, 2023
6 checks passed
@hangqianjun hangqianjun deleted the issue/9/survey_non_uniformity branch December 18, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants