Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lephare keywords from stage params to unblock pipeline creation. #41

Merged
merged 1 commit into from
May 15, 2024

Conversation

drewoldag
Copy link
Collaborator

We were using lephare keywords to define stage parameters, but that was breaking rail pipelines when trying to pickle a pipeline with a keyword included. This PR removes lephare keywords in favor of simple strings.

@drewoldag drewoldag requested a review from raphaelshirley May 14, 2024 23:03
@drewoldag drewoldag self-assigned this May 14, 2024
Copy link
Collaborator

@raphaelshirley raphaelshirley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep as we discussed it is better for RAIL to use string dictionaries. We may change some of the lephare functionality to allow use of string dictionaries for some of the higher level lephare functionality.

@raphaelshirley raphaelshirley merged commit 8b60454 into main May 15, 2024
5 checks passed
@raphaelshirley raphaelshirley deleted the awo/no-keyword-stage-params branch May 15, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants