[ORD-1873] Enable use for Ioredis, redis@3, & redi@2 #2
Conversation
package.json
Outdated
| "@typescript-eslint/eslint-plugin": "^4.8.1", | ||
| "@typescript-eslint/parser": "^4.8.1", | ||
| "ava": "^3.13.0", | ||
| "eslint": "^7.13.0", | ||
| "eslint-config-prettier": "^6.15.0", | ||
| "eslint-plugin-prettier": "^3.1.4", | ||
| "ioredis": "^5.4.1", | ||
| "node": "^18.20.4", |
There was a problem hiding this comment.
You don't install note via package.json, node and npm need to be installed before you can use the package.json
look in the CI workflow file
There was a problem hiding this comment.
oh whoops thats right, forgot about that. Then should I change 12 => in the npm-publish.yml file instead (once I reverse the last commit)
- uses: actions/setup-node@v1
with:
node-version: 12 =>18
package.json
Outdated
| "prepare": "npm run build", | ||
| "build": "rm -rf ./dist && tsc" | ||
| "_prepare": "npm run build", | ||
| "_build": "rm -rf ./dist && tsc" |
There was a problem hiding this comment.
thought we already did, sorry should've caught that myself
| // Redis@3 & Redis@2 need to be promisified b/c they can't return promises (Redis@4 can) | ||
| // Ioredis already returns promises, so it returns the following warning when used | ||
| // (node:21449) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake. |
There was a problem hiding this comment.
Thanks. I got excited when I upgraded to node 18 and it went away but when I did it the right way the warnings stayed. Can address this another time (maybe when we upgrade redis version or remove it and only use ioredis)
ambient.d.ts
Outdated
| @@ -0,0 +1 @@ | |||
| declare module "redis3"; | |||
There was a problem hiding this comment.
Don't think we need this, we just use "redis" as redis 3 now
This reverts commit 48e49ac.
No description provided.