[COR-68] Add registry of loaded RPC clients and expose discovery metadata #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add registry - Update prettier & eslint versions
denwilliams
reviewed
May 28, 2021
| return client.load(metaPath); | ||
| }; | ||
| exports.registry = new Registry(); | ||
| exports.Registry = Registry; |
There was a problem hiding this comment.
Similar to the other PR, this should export WELL_KNOWN_META_PATH which will be /client in this case, not /server
denwilliams
requested changes
May 28, 2021
index.js
Outdated
| return loadClient; | ||
| } | ||
|
|
||
| createWellKnownHandler() { |
There was a problem hiding this comment.
I think createWellKnownErrorHandler
denwilliams
reviewed
May 28, 2021
midhilkari
changed the title
midhilkari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump to v5..0.0-beta:
Relates to: COR-68