Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Smooth ReaderFooter appearance #1103

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Smooth ReaderFooter appearance #1103

wants to merge 3 commits into from

Conversation

CD-Z
Copy link
Contributor

@CD-Z CD-Z commented Jun 11, 2024

fixed the appearance of the ReaderFooter through workaround

@CD-Z CD-Z force-pushed the feature/smooth_ReaderFooter_appearance branch from cd3b87a to 52ccb46 Compare June 23, 2024 18:14
@nyagami
Copy link
Member

nyagami commented Jun 25, 2024

What if user changes the orentiation from landscape to portrait? Doest it look weird

@CD-Z
Copy link
Contributor Author

CD-Z commented Jun 25, 2024

What if user changes the orentiation from landscape to portrait? Doest it look weird

No why should it. It works exactly the same way as at has until now with the difference that it takes the bottom safe area inset into acount.

@nyagami
Copy link
Member

nyagami commented Jun 27, 2024

Try these steps:

  • open chapter
  • hide navbar
  • swipe to open drawer
  • choose another chapter
    -> bottom inset now is 0

@CD-Z
Copy link
Contributor Author

CD-Z commented Jun 30, 2024

Try these steps:

* open chapter

* hide navbar

* swipe to open drawer

* choose another chapter
  -> bottom inset now is 0

fixed this issue with initialWindowMetrics, it will now always instantly display the safeAreaInsets

@CD-Z CD-Z force-pushed the feature/smooth_ReaderFooter_appearance branch from 4f528c0 to 2f82f08 Compare July 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CD-Z @nyagami