Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN updates #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

orbitalturtle
Copy link

This PR updates CLN to a branch where we can make payments successfully. To do so we pull in CLN's Dockerfile and related files that we need to build the binary.

We can probably remove most of these files once CLN releases v24.08. But in the meantime, this will help with testing.

A couple notes when making payments however:

  • It works best when LNDK is updated to include transient keys for signing invoice requests lndk-org/lndk#133
    But even with this change included, there is an annoying error case, where if we hit a single error, all subsequent payments to the same offer fail. I'm not sure why but plan to look into it further.
  • Similar to when paying Eclair offers, payments of 1000 msats fail because they are too small, but payments of 10000 msats succeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant