Don't fill notes that overlap slightly #7569
Open
+82
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JohannesLorenz
added
needs style review
|
How do other DAWs fill notes? Trying to make sure that this is the expected behavior. |
messmerd
reviewed
Jan 13, 2025
| @@ -766,6 +770,79 @@ void PianoRoll::fitNoteLengths(bool fill) | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| bool fillGapsBetweenNotesInVector( | |||
There was a problem hiding this comment.
Suggested change
| bool fillGapsBetweenNotesInVector( | |
| static bool fillGapsBetweenNotesInVector( |
This could be static since it's only used in this translation unit.
regulus79
reviewed
Mar 21, 2025
| // TODO remove the code for fill=true | ||
| // it has been replaced by fillGapsBetweenNotes() | ||
| bool fill = false; | ||
|
|
There was a problem hiding this comment.
Would it make sense to also remove the old code as part of this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a note overlaps the next by a hair, pressing shift+F will fill it all the way across the other note. That's annoying.
This PR fixes that by only filling overlapping notes if the overlap by more than 50%