Fix crash on Xpressive when using integrate function
#7499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Rossmaxx
changed the title
integrate function
sakertooth
reviewed
Sep 18, 2024
|
Actually, this is a simple one line fix from what I looked at. If you don't mind, I'll close this one and open my fix. The rest seems to be plain renames. |
|
@gnudles since you didn't reply, I believe you have forgotten about this. I'll give a one week notice and if you don't respond, I'll close this one and take over with my version of the fix. I'll still credit you in the fix. |
|
Please wait with that. Changing types can be dangerous. I do not have too much free time to work on this, but it is better that I will perform the changes |
|
Ok then. |
|
@Rossmaxx thank you for your patience |
gnudles
force-pushed
the
xpressive_bug_fix2
branch
from
10a6e09
to
5a5bd62
Compare
gnudles
force-pushed
the
xpressive_bug_fix2
branch
from
5a5bd62
to
399769b
Compare
|
@sakertooth would you like to merge it? |
sakertooth
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7468