Widget highlighting and shortcut system implementation #7488
Conversation
| @@ -40,6 +42,36 @@ namespace lmms::Clipboard | |||
| StringPair, | |||
| Default | |||
| }; | |||
|
|
|||
| enum StringPairDataType | |||
There was a problem hiding this comment.
The name could probably be shortened to just DataType or something.
There was a problem hiding this comment.
Which one is better: KeyType or PairType or PairDataType or maybe CarriedDataType? I think DataType doesn't say anything about the StringPairDrag system and it could be confusing because there is also a Default mime type, but I guess this can be fixed with a comment.
I would like to get a finalized name because this change would effect 30 files.
| } | ||
|
|
||
| std::vector<InteractiveModelView::ModelShortcut> FloatModelEditorBase::getShortcuts() |
There was a problem hiding this comment.
This could return a const reference to avoid copying.
| class ModelShortcut | ||
| { | ||
| public: | ||
| inline ModelShortcut() {} |
There was a problem hiding this comment.
Constructors and other methods are already implicitly inline so the inline specifier can be removed.
| static QColor getHighlightColor(); | ||
| static void setHighlightColor(QColor& color); | ||
| protected: | ||
| class ModelShortcut |
There was a problem hiding this comment.
Since this is a simple class that is just used for holding data, you could make it a struct and remove the "m_" prefix from the data members.
| return shortcuts; | ||
| } | ||
|
|
||
| void FloatModelEditorBase::processShortcutPressed(size_t shortcutLocation, QKeyEvent* event) |
There was a problem hiding this comment.
It would be nice if the size_t shortcutLocation parameter could be const ModelShortcut& instead.
This PR contains multiple changes and overall it is focused on improving lmms functionality communication with the user and on immediate feedback to the user.
These changes are the following:
StringPairDragsystem and theStringPairsystem now uses a unifiedenumas key instead of custom strings. Before this, key names weren't documented and they were scattered across multiple files.StringPairkey while dragging or copying. If the user starts to drag a clip, the other clips will be highlighted to show that they can accept the datatype associated with the drag event.FloatModelEditorBase) and all clips. I plan to implement it in other widgets in the future (if this gets merged).Problems:
ClipView::getClipStringPairTypeandTrackView::getTrackStringPairTypedoes not implement Special types of tracks (video, event)ClipView::dropEventcopying code because I found that this condition is never true:Picture showing highlighting (for knobs and clips separately):