Adding proportional scrolling #7476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checked it out and it's working great! Thanks. |
|
Alright, I sped up the horizontal scrolling in the Piano Roll and Automation Editor by about 3x, so now the Piano Roll's horizontal scrolling is closer to the speed of the vertical scrolling. I didn't do exactly 3x, since that made it scroll exactly 1 beat, which made the grid pattern line up and look odd like it wasn't scrolling. |
|
It seems good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7474 by making the scroll amount change based on the zoom amount.
The implementation is slightly different in the
SongEditorversus thePianoRolland theAutomationEditor, since theSongEditorhas precise zoom control while the others have zoom levels. I opted to usepixelsPerBar()in theSongEditorto calculate the zoom level for simplicity, since the zooming model is in log scale.I actually had this on feature my mind awhile ago when I was implementing continuous autoscrolling, but I decided to leave it to a different pr and forgot about it. Now I've been reminded, so here it is.
Also, please let me know if the scrolling speed is too fast/too slow. Currently the scrolling speed is equal to the old scrolling speed at default zoom.