Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat MixerChannelView files #7431

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Reformat MixerChannelView files #7431

merged 1 commit into from
Sep 30, 2024

Conversation

sakertooth
Copy link
Contributor

@sakertooth sakertooth commented Aug 5, 2024 •
edited
Loading

I realized we merged the MixerChannelView addition, but the formatting wasn't correct.

Rossmaxx
Rossmaxx reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is it for now.

include/MixerChannelView.h Show resolved Hide resolved
src/gui/MixerChannelView.cpp Show resolved Hide resolved
messmerd
messmerd reviewed Sep 13, 2024
View reviewed changes
include/MixerChannelView.h Outdated Show resolved Hide resolved
include/MixerChannelView.h Outdated Show resolved Hide resolved
messmerd
messmerd reviewed Sep 14, 2024
View reviewed changes
src/gui/MixerChannelView.cpp Outdated Show resolved Hide resolved
include/MixerChannelView.h Outdated Show resolved Hide resolved
@sakertooth sakertooth changed the title Reformat MixerChannelView.cpp and MixerChannelView.h Fix up MixerChannelView Sep 14, 2024
@sakertooth sakertooth marked this pull request as draft September 17, 2024 17:44
@sakertooth sakertooth marked this pull request as ready for review September 17, 2024 17:56
@sakertooth sakertooth changed the title Fix up MixerChannelView Tidy up MixerChannelView Sep 17, 2024
Rossmaxx
Rossmaxx approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time we merge minor PRs like this.

@Rossmaxx
Copy link
Contributor

@sakertooth merge master and we good.

@sakertooth
Copy link
Contributor Author

These merge conflicts are too risky to deal with (already got segfaults when trying to merge master), so I'm starting over.

@sakertooth
Copy link
Contributor Author

I'm splitting the functional changes I made here into another PR. This PR will just be fixing the formatting since that was the main issue I had with these two files.

@sakertooth sakertooth changed the title Tidy up MixerChannelView Reformat MixerChannelView files Sep 30, 2024
@sakertooth sakertooth merged commit 860749a into LMMS:master Sep 30, 2024
11 checks passed
@sakertooth sakertooth deleted the reformat-mixer-channel-view branch September 30, 2024 23:32
@sakertooth sakertooth mentioned this pull request Oct 1, 2024
Merged
mmeeaallyynn pushed a commit to mmeeaallyynn/lmms that referenced this pull request Oct 27, 2024
@sakertooth @mmeeaallyynn
Reformat MixerChannelView classes (LMMS#7431)
4e04517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messmerd messmerd messmerd left review comments

@Rossmaxx Rossmaxx Rossmaxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakertooth @Rossmaxx @messmerd