Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pattern editor subwindow horizontal scaling #7409

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

szeli1
Copy link
Contributor

@szeli1 szeli1 commented Jul 30, 2024

closes #7313

Made constants in TrackView static, replaced the configmanager "compacttrackbuttons" with static functions in TrackView.

Modified TrackContainerView::scrollArea to have the ability to scroll horizontally.
Changed TrackContainerView::realignTracks to clamp at a minimum size.

Please review carefully. (especially the TrackView static changes)

@YesImAsh
Copy link

YesImAsh commented Aug 5, 2024

You did an amazing job. Thank you

@Gabrielxd195
Copy link

This is great, now the BB editor will be better used. Do you think this can also be applied to File Explorer in the future? Because you need it.

@szeli1
Copy link
Contributor Author

szeli1 commented Aug 21, 2024

Do you think this can also be applied to File Explorer in the future?

You could make a feature request about it and see if somebody implements it.

@Gabrielxd195
Copy link

@szeli1 I proposed horizontal sliding in the file browser along with another improvement in #4599 but since I didn't know anything about Github at that time they closed the issue for me for having made two suggestions in the same issue and everything was left there, no one has talked about this, I think I should have suggested different matters.

@szeli1
Copy link
Contributor Author

szeli1 commented Aug 22, 2024

they closed the issue for me for having made two suggestions

The closed it because one suggestion was the same as an older one.
You are right about you shouldn't make an issue about 2 things. You definitely should open new issues if you have feature requests / know about bugs, but make sure nobody suggested your suggestion before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scrolling to the B + B editor to make it easier
3 participants