Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add looping option to SlicerT #7386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

regulus79
Copy link
Contributor

Problem

Currently, segments do not loop in SlicerT. This makes sense for many applications such as drums, but if you want to use SlicerT to make unique sounds by looping short segments, that is currently not possible.

Changes

  • If looping is enabled, then when there are zero frames left in the note (notesLeft<=0), the note position is reset back to the start of the slice.
  • A new LedCheckBox was added to the plugin interface to let the user toggle looping.
  • loopEnable was added as a saveable/loadable setting.

This pull request partially addresses #7364

2024-07-19.15-19-04.mp4

@Rossmaxx
Copy link
Contributor

Looks good so far, but I don't think that's the looping behaviour. Sounds more like the "rubberband" behaviour, in the sense that it goes backwards too. Shouldn't loops be unidirectional?

@DanielKauss you might wanna look into this.

@regulus79
Copy link
Contributor Author

I believe the loop is unidirectional, but it's just hard to hear when the slices are so short. Here's an example with longer slices:

2024-07-20.12-33-22.mp4

@Rossmaxx
Copy link
Contributor

Yeah mb.

@bratpeki
Copy link
Contributor

My first thought is: You need to be able to toggle that. If your slice is not exactly to a measure (eg. 1/4), and it doesn't loop, it has a fade option which makes it sound fine. If it loops, it'll go back and maybe make nasty short spikes in the output.

My second though is: If you have sections you wanna loop like that, why not use AFP? It already has a whole slew of options regarding looping, which you would have to implement in SlicerT.

What if I want ping pong looping on the third slice, forward of the fifth, and no looping on the rest of the slices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants