Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add first attempt at python library #349

Merged
merged 53 commits into from
Dec 21, 2024
Merged

add first attempt at python library #349

merged 53 commits into from
Dec 21, 2024

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Dec 9, 2024

add a few updates including cmake and a first cut at a python wrapper using nanobind

@SimonHeybrock
Copy link
Contributor

Interesting development!

Wondering what your plans are regarding errors? In Scipp we are translating the "error codes" of this library into exceptions, which is more in line with how most Python software operates.

@phlptp
Copy link
Collaborator Author

phlptp commented Dec 13, 2024

Interesting development!

Wondering what your plans are regarding errors? In Scipp we are translating the "error codes" of this library into exceptions, which is more in line with how most Python software operates.

Not entirely sure yet, this is more of an experiment at the moment. As we get further along we may borrow what you are doing with Scipp

@phlptp
Copy link
Collaborator Author

phlptp commented Dec 21, 2024

@SimonHeybrock I am going to mimic the C++ library for now and not handle exceptions, that may or may not be how we want to have things work longer term. The simplest approach may be to add a check for error units wherever there is a string translation. But for a first try I am not doing that.

@phlptp phlptp merged commit b8bf817 into main Dec 21, 2024
57 checks passed
@phlptp phlptp deleted the add_python branch December 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants