Copy Notebooks Automatically #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilumsden Is there any specific reason the notebooks were originally copied one-by-one instead of the whole directory like the |
|
Mainly because copying directories is very finicky in Dockerfiles. If you do it right, it's fine. But, if you don't, you can cause a ton of issues. |
michaelmckinsey1
force-pushed
the
copyall-notebooks
branch
from
93ab9b4 to
ca617e8
Compare
|
@ilumsden Does the way the notebooks directory is copied avoid the Docker issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy over all notebooks in the
notebooksdirectory so we do not need to update the Dockerfile for each new notebook.