Feature/sunadjoint #559
Feature/sunadjoint #559
Conversation
Co-authored-by: Daniel R. Reynolds <[email protected]>
| .. c:function:: SUNErrCode SUNAdjointStepper_RecomputeFwd(SUNAdjointStepper adj_stepper, int64_t start_idx,\ | ||
| sunrealtype t0, sunrealtype tf, N_Vector y0) | ||
|
|
||
| Evolves the forward system in time from start_idx/t0 to stop_idx/tf with dense checkpointing. |
There was a problem hiding this comment.
Unclear if start_idx/t0 is a division?
| Allocates a ``SUNMemory`` object whose ``ptr`` field is allocated for | ||
| ``mem_size`` bytes and is of type ``mem_type``. The new object will have | ||
| ownership of ``ptr`` and will be deallocated when | ||
| :c:func:`SUNMemoryHelper_Dealloc` is called. |
There was a problem hiding this comment.
This appears to be copied from SUNMemoryHelper_Alloc, and it's unclear to me if the description needs to be different to account for the stride argument.
| The implementation provides the following operations defined by the | ||
| ``SUNMemoryHelper`` API: | ||
|
|
||
| .. c:function:: SUNErrCode SUNMemoryHelper_Alloc_Sys(SUNMemoryHelper helper, \ |
There was a problem hiding this comment.
I realize this is following the convention of the other SUNMemoryHelpers so this will need to be considered outside this PR, but I don't see why these should be made public. Shouldn't users call SUNMemoryHelper_Alloc rather than SUNMemoryHelper_Alloc_Sys?
There was a problem hiding this comment.
@gardner48 Do you think we should document the implementation specific overrides of the generic functions? We do so somewhat inconsistently as of now .
Co-authored-by: Steven Roberts <[email protected]>
Co-authored-by: Steven Roberts <[email protected]>
No description provided.